Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gfa path export #48

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Gfa path export #48

merged 4 commits into from
Sep 23, 2024

Conversation

dkhofer
Copy link
Collaborator

@dkhofer dkhofer commented Sep 18, 2024

No description provided.

@@ -85,7 +85,7 @@ CREATE TABLE path_edges (
FOREIGN KEY(edge_id) REFERENCES edges(id),
FOREIGN KEY(path_id) REFERENCES path(id)
) STRICT;
CREATE UNIQUE INDEX path_edges_uidx ON path_edges(path_id, edge_id);
CREATE UNIQUE INDEX path_edges_uidx ON path_edges(path_id, edge_id, index_in_path);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resolves the constraint violations that Bob saw

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same sequence (or pair of edges) can show up multiple times in a path with this

@dkhofer dkhofer requested a review from Chris7 September 18, 2024 19:26
src/models/path.rs Outdated Show resolved Hide resolved
src/models/path_edge.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Chris7 Chris7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good. Only comment is about a convention i've been trying to use for column table order in our generic query methods

@dkhofer dkhofer merged commit 75f0212 into main Sep 23, 2024
1 check passed
@Chris7 Chris7 deleted the gfa-path-export branch September 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants