Add sequence cache #26
Conversation
| pub fn lookup( | ||
| sequence_cache: &mut SequenceCache<'a>, | ||
| sequence_type: &'a str, | ||
| sequence: String, |
There was a problem hiding this comment.
i think this will result in ownership issues where String is moved here but not returned out. &String can resolve that
There was a problem hiding this comment.
I was actually fighting the compiler about this yesterday. I couldn't get it to work with &str. I tried with &String just now and got the same problem, which is that the sequence cache exists outside the for loop that's processing the VCF records. The sequence that's being cached gets created inside that for loop, so any reference to it is transient (could go away from one iteration of the for loop to the next), so the sequence reference can't get added to the cache.
src/main.rs
Outdated
| .sequence_type("DNA") | ||
| .sequence(&sequence) | ||
| .save(sequence_cache.conn); | ||
| let new_sequence = |
There was a problem hiding this comment.
i think you can actually do this w/o the additional lookup by using the build part of the builder to get the sequence object. So you would have the builder object as a var, call save to get the hash, and build to get the sequence object.
dkhofer
force-pushed
the
cache-sequences
branch
from
5f240fb
to
9ea0369
Compare
No description provided.