-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Half matrix and components #1708
Open
yhmtsai
wants to merge
12
commits into
half_type
Choose a base branch
from
half_matrix
base: half_type
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
This is related to the build system.
reg:testing
This is related to testing.
type:solver
This is related to the solvers
type:matrix-format
This is related to the Matrix formats
type:factorization
This is related to the Factorizations
type:reordering
This is related to the matrix(LinOp) reordering
mod:all
This touches all Ginkgo modules.
labels
Oct 24, 2024
yhmtsai
force-pushed
the
half_matrix
branch
2 times, most recently
from
October 25, 2024 08:20
8f3a17d
to
b7d4a15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:ready-for-review
This PR is ready for review
mod:all
This touches all Ginkgo modules.
reg:build
This is related to the build system.
reg:testing
This is related to testing.
type:factorization
This is related to the Factorizations
type:matrix-format
This is related to the Matrix formats
type:reordering
This is related to the matrix(LinOp) reordering
type:solver
This is related to the solvers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the matrix and components (like arrary/device_matrix_data) with half precision support
Also, to avoid touch the files, which are not related to this PR, I add several type list with half additionally.
For example, RealValueTypes -> RealValueTypesWithHalf and next_precision -> next_precision_with_half
(We will add bfloat16 in the future, so maybe do not use Half)
for the friend and corresponding function
If we only use next in friend and function
Moreover, the second one does not work when we fallback the next_precision_with_half to next_precision by disabling half because next<next<value_type>> is value_type without half now. However, the first one always work.
TODO:
add as_device_type to sycl for gko::half <-> sycl::halfmove to Sycl device_type mapping #1710