-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additive read distributed #1650
Open
fritzgoebel
wants to merge
8
commits into
develop
Choose a base branch
from
additive_read_distributed
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzgoebel
added
is:new-feature
A request or implementation of a feature that does not exist yet.
1:ST:WIP
This PR is a work in progress. Not ready for review.
type:distributed-functionality
labels
Jul 16, 2024
fritzgoebel
force-pushed
the
additive_read_distributed
branch
2 times, most recently
from
July 23, 2024 15:21
71c1a41
to
7ab6bf6
Compare
fritzgoebel
removed
the
1:ST:WIP
This PR is a work in progress. Not ready for review.
label
Jul 23, 2024
MarcelKoch
requested changes
Aug 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly smaller stuff. Only the communication change would be significant, if that would be done.
fritzgoebel
force-pushed
the
additive_read_distributed
branch
from
October 18, 2024 15:46
7ab6bf6
to
69d8d86
Compare
MarcelKoch
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1:ST:ready-for-review
This PR is ready for review
is:new-feature
A request or implementation of a feature that does not exist yet.
mod:all
This touches all Ginkgo modules.
type:distributed-functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to communicate overlap in the distributed matrix'
read_distributed
. If the option is used, nonzero entries present in multiple ranks are added up on the owning rank rather than thrown away inread_distributed
.This can be useful e.g. if in a domain decomposed finite element setting, each rank assembles their local contribution to a global system matrix and when assembling the global system matrix information on the subdomain boundaries has to be exchanged.
TODO: