Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple cache storages feature #156

Merged
merged 32 commits into from
Nov 18, 2024
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6d35c14
Add multiple cache storages feature
ikesyo Nov 7, 2024
5953d6c
Pass storages to `CacheSystem.cacheFrameworks`
ikesyo Nov 8, 2024
a24f7c9
Refactor to remove isProducingCacheEnabled
ikesyo Nov 8, 2024
d7bd9ff
Refactor to remove isConsumingCacheEnabled
ikesyo Nov 8, 2024
e7b20c5
Improve logging
ikesyo Nov 8, 2024
0f1c98a
debugging
ikesyo Nov 8, 2024
8750153
Add test case for storages cache mode
ikesyo Nov 11, 2024
8c7c16e
Update `build-pipeline.md` for `.storages` cache mode
ikesyo Nov 11, 2024
f6cbef1
debugging
ikesyo Nov 11, 2024
413bb12
Add StorageConfig struct
ikesyo Nov 12, 2024
c3d9efa
Address naming convention issues
ikesyo Nov 12, 2024
25f5fcb
Replace `case storage` with static func
ikesyo Nov 12, 2024
82ec106
Replace `case disabled` with static func
ikesyo Nov 12, 2024
086970f
Merge branch 'main' into multiple-cache-storages
ikesyo Nov 12, 2024
7434f6b
Rename to LocalDiskCacheStorage
ikesyo Nov 12, 2024
a451614
Introduce ProjectCacheStorage
ikesyo Nov 12, 2024
c22ed6f
Replace `case project` with static func (using ProjectCacheStorage)
ikesyo Nov 12, 2024
0006fbb
Introduce CachePolicy and replace CacheMode with an array of CachePolicy
ikesyo Nov 12, 2024
4d8abab
Update documentation
ikesyo Nov 12, 2024
76ae5af
Avoid direct usages of `type(of: storage)`
ikesyo Nov 12, 2024
ff1d483
Make LocalDiskCacheStorage and ProjectCacheStorage internal
ikesyo Nov 14, 2024
4712f89
Use some over any for arguments
ikesyo Nov 14, 2024
3d333e6
[CI] macos-15 image is required to use Xcode 16
ikesyo Nov 14, 2024
0c81a2e
Add info log when a cache is not found when restoring as well as `.su…
ikesyo Nov 14, 2024
d71053b
Fix format
ikesyo Nov 14, 2024
ed52625
Use some over any for arguments
ikesyo Nov 14, 2024
4de26b5
Add inline comment
ikesyo Nov 14, 2024
bced0e2
Reduce duplication
ikesyo Nov 14, 2024
dfe443c
Revert "Reduce duplication"
ikesyo Nov 14, 2024
acdd251
Reduce duplication
ikesyo Nov 14, 2024
afafa8d
Revert "debugging"
ikesyo Nov 14, 2024
2720cde
Add `[Runner.Options.CachePolicy].disabled`
ikesyo Nov 15, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/docc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ env:
DEVELOPER_DIR: "/Applications/Xcode_16.0.app/Contents/Developer"
jobs:
DocC:
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Build DocC
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
xcode_version: ["16.0"]
env:
DEVELOPER_DIR: "/Applications/Xcode_${{ matrix.xcode_version }}.app/Contents/Developer"
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Install SwiftLint
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ env:
jobs:
release:
name: Build and Upload Artifact Bundle
runs-on: macos-14
runs-on: macos-15
steps:
- uses: actions/checkout@v4
- name: Resolve Dependencies
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- "16.0" # 6.0
env:
DEVELOPER_DIR: "/Applications/Xcode_${{ matrix.xcode_version }}.app/Contents/Developer"
runs-on: macos-14
runs-on: macos-15
steps:
- name: Get swift version
run: swift --version
Expand Down
37 changes: 19 additions & 18 deletions Sources/ScipioKit/Producer/Cache/CacheSystem.swift
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ struct CacheSystem: Sendable {
static let defaultParalellNumber = 8
private let pinsStore: PinsStore
private let outputDirectory: URL
private let storage: (any CacheStorage)?
Copy link
Collaborator Author

@ikesyo ikesyo Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the introduction of cache policies, storages may be different on when saving caches and when restoring caches. So removed the property and passes by arguments instead.

private let fileSystem: any FileSystem

struct CacheTarget: Hashable, Sendable {
Expand Down Expand Up @@ -139,18 +138,23 @@ struct CacheSystem: Sendable {
init(
pinsStore: PinsStore,
outputDirectory: URL,
storage: (any CacheStorage)?,
fileSystem: any FileSystem = localFileSystem
) {
self.pinsStore = pinsStore
self.outputDirectory = outputDirectory
self.storage = storage
self.fileSystem = fileSystem
}

func cacheFrameworks(_ targets: Set<CacheTarget>) async {
let chunked = targets.chunks(ofCount: storage?.parallelNumber ?? CacheSystem.defaultParalellNumber)
func cacheFrameworks(_ targets: Set<CacheTarget>, to storages: [any CacheStorage]) async {
for storage in storages {
await cacheFrameworks(targets, to: storage)
}
}

private func cacheFrameworks(_ targets: Set<CacheTarget>, to storage: some CacheStorage) async {
let chunked = targets.chunks(ofCount: storage.parallelNumber ?? CacheSystem.defaultParalellNumber)

let storageName = storage.displayName
for chunk in chunked {
await withTaskGroup(of: Void.self) { group in
for target in chunk {
Expand All @@ -159,10 +163,10 @@ struct CacheSystem: Sendable {
let frameworkPath = outputDirectory.appendingPathComponent(frameworkName)
do {
logger.info(
"🚀 Cache \(frameworkName) to cache storage",
"🚀 Cache \(frameworkName) to cache storage: \(storageName)",
metadata: .color(.green)
)
try await cacheFramework(target, at: frameworkPath)
try await cacheFramework(target, at: frameworkPath, to: storage)
} catch {
logger.warning("⚠️ Can't create caches for \(frameworkPath.path)")
}
Expand All @@ -173,10 +177,10 @@ struct CacheSystem: Sendable {
}
}

private func cacheFramework(_ target: CacheTarget, at frameworkPath: URL) async throws {
private func cacheFramework(_ target: CacheTarget, at frameworkPath: URL, to storage: any CacheStorage) async throws {
let cacheKey = try await calculateCacheKey(of: target)

try await storage?.cacheFramework(frameworkPath, for: cacheKey)
try await storage.cacheFramework(frameworkPath, for: cacheKey)
}

func generateVersionFile(for target: CacheTarget) async throws {
Expand Down Expand Up @@ -210,8 +214,8 @@ struct CacheSystem: Sendable {
case failed(LocalizedError?)
case noCache
}
func restoreCacheIfPossible(target: CacheTarget) async -> RestoreResult {
guard let storage = storage else { return .noCache }

func restoreCacheIfPossible(target: CacheTarget, storage: some CacheStorage) async -> RestoreResult {
do {
let cacheKey = try await calculateCacheKey(of: target)
if try await storage.existsValidCache(for: cacheKey) {
Expand All @@ -225,12 +229,6 @@ struct CacheSystem: Sendable {
}
}

private func fetchArtifacts(target: CacheTarget, to destination: URL) async throws {
Copy link
Collaborator Author

@ikesyo ikesyo Nov 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unused.

guard let storage = storage else { return }
let cacheKey = try await calculateCacheKey(of: target)
try await storage.fetchArtifacts(for: cacheKey, to: destination)
}

func calculateCacheKey(of target: CacheTarget) async throws -> SwiftPMCacheKey {
let targetName = target.buildProduct.target.name
let pin = try retrievePin(package: target.buildProduct.package)
Expand All @@ -247,7 +245,10 @@ struct CacheSystem: Sendable {
buildOptions: buildOptions,
clangVersion: clangVersion,
xcodeVersion: xcodeVersion,
scipioVersion: currentScipioVersion
// Making the cache key compatible with 0.24.0 temporarily for easier debugging.
//
// TODO: revert this before merging
scipioVersion: "578ce98d236e79dad3e473cb11153e867be07174"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the feature, we're better to add --disable-scipio-version-management option for this purpose.
It's useful for the development phase.

Copy link
Collaborator Author

@ikesyo ikesyo Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabling when developing is not a solution, because if excluding scipioVersion from cache keys, those are not compatible with the cache keys generated by release-versioned Scipio.

Ideally we should introduce some kind of Scipio's cache versioning and increment it when there are some incompatible changes to built frameworks (but it'll make Scipio's development and review process a bit complicated).

)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,37 +3,33 @@ import ScipioStorage
import PackageGraph
import TSCBasic

public struct LocalCacheStorage: CacheStorage {
struct LocalDiskCacheStorage: CacheStorage {
private let fileSystem: any FileSystem

public var parallelNumber: Int? { nil }
var parallelNumber: Int? { nil }

enum Error: Swift.Error {
case cacheDirectoryIsNotFound
}

public enum CacheDirectory: Sendable {
case system
case custom(URL)
}

private let cacheDirectroy: CacheDirectory
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Directroy

private let baseURL: URL?

public init(cacheDirectory: CacheDirectory = .system, fileSystem: FileSystem = localFileSystem) {
self.cacheDirectroy = cacheDirectory
/// - Parameters:
/// - baseURL: The base url for the local disk cache. When it is nil, the system cache directory (`~/Library/Caches`) will be used.
init(baseURL: URL?, fileSystem: FileSystem = localFileSystem) {
self.baseURL = baseURL
self.fileSystem = fileSystem
}

private func buildBaseDirectoryPath() throws -> URL {
let cacheDir: URL
switch cacheDirectroy {
case .system:
if let baseURL {
cacheDir = baseURL
} else {
guard let systemCacheDir = fileSystem.cachesDirectory else {
throw Error.cacheDirectoryIsNotFound
}
cacheDir = systemCacheDir.asURL
case .custom(let customPath):
cacheDir = customPath
}
return cacheDir.appendingPathComponent("Scipio")
}
Expand All @@ -51,7 +47,7 @@ public struct LocalCacheStorage: CacheStorage {
.appendingPathComponent(xcFrameworkFileName(for: cacheKey))
}

public func existsValidCache(for cacheKey: some CacheKey) async -> Bool {
func existsValidCache(for cacheKey: some CacheKey) async -> Bool {
do {
let xcFrameworkPath = try cacheFrameworkPath(for: cacheKey)
return fileSystem.exists(xcFrameworkPath.absolutePath)
Expand All @@ -60,7 +56,7 @@ public struct LocalCacheStorage: CacheStorage {
}
}

public func cacheFramework(_ frameworkPath: URL, for cacheKey: some CacheKey) async {
func cacheFramework(_ frameworkPath: URL, for cacheKey: some CacheKey) async {
do {
let destination = try cacheFrameworkPath(for: cacheKey)
let directoryPath = destination.deletingLastPathComponent()
Expand All @@ -72,7 +68,7 @@ public struct LocalCacheStorage: CacheStorage {
}
}

public func fetchArtifacts(for cacheKey: some CacheKey, to destinationDir: URL) async throws {
func fetchArtifacts(for cacheKey: some CacheKey, to destinationDir: URL) async throws {
let source = try cacheFrameworkPath(for: cacheKey)
let destination = destinationDir.appendingPathComponent(xcFrameworkFileName(for: cacheKey))
try fileSystem.copy(from: source.absolutePath, to: destination.absolutePath)
Expand Down
10 changes: 10 additions & 0 deletions Sources/ScipioKit/Producer/Cache/ProjectCacheStorage.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import Foundation
import ScipioStorage

/// The pseudo cache storage for "project cache policy", which treats built frameworks under the project's output directory (e.g. `XCFrameworks`)
/// as valid caches but does not saving / restoring anything.
struct ProjectCacheStorage: CacheStorage {
func existsValidCache(for cacheKey: some ScipioStorage.CacheKey) async throws -> Bool { false }
func fetchArtifacts(for cacheKey: some ScipioStorage.CacheKey, to destinationDir: URL) async throws {}
func cacheFramework(_ frameworkPath: URL, for cacheKey: some ScipioStorage.CacheKey) async throws {}
}
9 changes: 9 additions & 0 deletions Sources/ScipioKit/Producer/CacheStorage+DisplayName.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import ScipioStorage

extension CacheStorage {
/// The display name of the cache storage used for logging purpose
var displayName: String {
// TODO: Define the property as CacheStorage's requirement in scipio-cache-storage
"\(type(of: self))"
}
}
Loading