Add the ability to get the values safely #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 30, 2020 09:48
gieljnssns
reviewed
Oct 31, 2020
| name="kostalpyko", | ||
| version="v0.5", | ||
| packages=["tests", "kostalpyko"], | ||
| name="kostalpiko", |
|
@rcasula |
…values Fix indices and safely get values
In the PV inverter here I found an installation with three phases and 2 strings, which was not covered up until now for this library.
Added option for 2 strings / 3 phases, which is apparently also possible :-) Thanks for this great library!
Forgot to import the new constant DOUBLE_STRING_THREE_PHASES_INDICES
Shouldn't have done a PR close to midnight ;-) Thanks for catching the bug with the indices.
PR for configuration with 2 strings and 3 phases
Make latest PR (3 phases 2 strings) available in Pypi
|
Can we get, please, merged this (and eventually revert the rename only)? I'm waiting for this merge and as far as I found there are more ppl with this issue,... |
added 2 commits
August 25, 2022 18:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is really useful in cases like PIKO 3.0. At the moment if you try to get string2 value in a PIKO 3.0 you get a index out of bound exception.
I will make a PR to the kostalpiko-sensor-homeassistant repo to use these functions instead of raw_value[index].