Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evict ingress-nginx-controller from kube-downscaler scope #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QuantumEnigmaa
Copy link

Checklist

  • Update changelog in CHANGELOG.md.

@QuantumEnigmaa QuantumEnigmaa requested a review from a team December 26, 2024 11:12
@QuantumEnigmaa QuantumEnigmaa self-assigned this Dec 26, 2024
@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner December 26, 2024 11:12
Copy link
Contributor

@mcharriere mcharriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason for not setting this into the config repo?

I think that's a better suited place for this kind of settings.

@QuantumEnigmaa
Copy link
Author

setting this into the config repo

Do you mean as an extraObject in the kyverno-policies-connectivity ?

@mcharriere
Copy link
Contributor

mcharriere commented Dec 26, 2024

No, sorry. I meant either:

  • in the shared-config repo for gobal config (affecting all MCs)
  • or in the customer specific config repos to target specific MCs

There you should be able to use the values controller.annotations and controller.autoscaling.annotations to set the respective annotations on each resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants