Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init vendir #2

Merged
merged 3 commits into from
Nov 6, 2023
Merged

Init vendir #2

merged 3 commits into from
Nov 6, 2023

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Nov 2, 2023

This PR:

  • inits keda-app with vendir
  • creates cilium network policy

Be aware that we can only use a tag of KEDA right now because of kubernetes compatibily reasons.

  • v2.11 works starting from Kubernetes 1.25
  • v2.12 works starting from Kubernetes 1.26

TODOs:

Testing

Description on how keda can be tested.

  • fresh install works
    • AWS

Checklist

  • Update changelog in CHANGELOG.md.
  • Make sure values.yaml and values.schema.json are valid.

Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson QuentinBisson requested a review from a team November 2, 2023 15:45
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson
Copy link
Contributor Author

QuentinBisson commented Nov 5, 2023

App was tested on a workload cluster with a trigger based on REDIS

@QuentinBisson QuentinBisson enabled auto-merge (squash) November 5, 2023 15:31
@QuentinBisson QuentinBisson force-pushed the init-vendir branch 2 times, most recently from bf63694 to 5e1b3f7 Compare November 6, 2023 11:11
@QuentinBisson QuentinBisson requested a review from a team November 6, 2023 14:28
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of my own curiosity : why using vendir for this particular app instead of chart dependency ?

README.md Outdated Show resolved Hide resolved
@QuentinBisson
Copy link
Contributor Author

@QuantumEnigmaa Because this app was supposed to be maintained by @giantswarm/team-turtles and they prefer to use vendir

Signed-off-by: QuentinBisson <[email protected]>
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson merged commit 4b55b39 into main Nov 6, 2023
3 checks passed
@QuentinBisson QuentinBisson deleted the init-vendir branch November 6, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants