-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init vendir #2
Init vendir #2
Conversation
Signed-off-by: QuentinBisson <[email protected]>
Signed-off-by: QuentinBisson <[email protected]>
dce884c
to
72add61
Compare
f8be9f0
to
e4efa4e
Compare
App was tested on a workload cluster with a trigger based on REDIS |
bf63694
to
5e1b3f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of my own curiosity : why using vendir for this particular app instead of chart dependency ?
5e1b3f7
to
827899d
Compare
@QuantumEnigmaa Because this app was supposed to be maintained by @giantswarm/team-turtles and they prefer to use vendir |
Signed-off-by: QuentinBisson <[email protected]>
827899d
to
4f0c946
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR:
Be aware that we can only use a tag of KEDA right now because of kubernetes compatibily reasons.
TODOs:
Testing
Description on how keda can be tested.
Checklist
values.yaml
andvalues.schema.json
are valid.