Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document self service tenancy #2447

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

QuentinBisson
Copy link
Contributor

What this PR does / why we need it

Closes giantswarm/roadmap#3726

Things to check/remember before submitting

  • If it's one of your first contributions, make sure you've read the Contributing Guidelines.
  • Bump last_review_date in the front matter header of the pages you've touched.

@QuentinBisson QuentinBisson requested a review from a team January 14, 2025 13:44
@QuentinBisson QuentinBisson self-assigned this Jan 14, 2025
@QuentinBisson QuentinBisson requested a review from a team as a code owner January 14, 2025 13:44
Copy link
Contributor

@Rotfuks Rotfuks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

metadata:
labels:
# This is where the tenant label must be configured
observability.giantswarm.io/tenant: checkout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's better to call this tenant "my-team" ? I'm not sure we're in the context of an online shop for the examples here that this would be clear, are we? Sorry for throwing this curveball in slack :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For once I tried to use a real example :D I'll change that

@QuentinBisson QuentinBisson force-pushed the document-self-service-tenancy branch from d601070 to 4eebfe7 Compare January 14, 2025 14:38
@QuentinBisson QuentinBisson merged commit e430f3c into main Jan 14, 2025
8 checks passed
@QuentinBisson QuentinBisson deleted the document-self-service-tenancy branch January 14, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align grafana org-based multi-tenancy with loki tenants - Investigation
2 participants