Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clean up menu structure #2422

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Fix and clean up menu structure #2422

merged 14 commits into from
Dec 13, 2024

Conversation

marians
Copy link
Member

@marians marians commented Dec 13, 2024

This PR fixes the menus and does a few more things

  • config.yaml contained entries for pages. I removed those for the principal menu and specified the according data in the pages's front matter.
  • Several pages did not appear in the menu. I added them by adding the front matter data under the menu: key.
  • The content of page /overview/observability/logging/architecture/ moved up one level to /overview/observability/logging/, because there was no content on that node and the architecture page was the only one in the section.
  • Adjusted some linkTitle to make the menu more readable

Before:

image

@marians marians self-assigned this Dec 13, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file shouldn't be in the repo

Copy link
Contributor

This PR moves/renames or deletes some files. Please make sure to

  • maintain references (also important for images)
  • Maintain aliases in the front matter of moved markdown files

@marians marians marked this pull request as ready for review December 13, 2024 11:40
@marians marians requested a review from a team as a code owner December 13, 2024 11:40
Copy link
Contributor

@lyind lyind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to deal with empty descriptions without triggering the front-matter validator.

Otherwise LGTM

src/content/tutorials/registry/_index.md Show resolved Hide resolved
@marians marians enabled auto-merge (squash) December 13, 2024 11:45
@marians marians merged commit 07a3288 into main Dec 13, 2024
8 of 9 checks passed
@marians marians deleted the fix-vintage-menu branch December 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants