Adapt header and footer to new giantswarm.io template #2389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
This PR moves/renames or deletes some files. Please make sure to
|
marians
commented
Dec 11, 2024
Comment on lines
+3
to
+4
| {{ $observer := resources.Get "scripts/IntersectionObserver.js" }} | ||
| {{ $js := slice $aside $base $observer | resources.Concat "js/docs.js" | resources.Minify | fingerprint }} |
There was a problem hiding this comment.
This adds the intersection observer JS file to our main JS, to avoid the separate HTTP request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the header and footer to match the recent giantswarm.io site update.
It turned out to be way too complicated to get the header with navigation menu copied into the docs site. So I went for a reduced version showing the logo and "Contact us" button, to keep some visual consistency with the core website.
To make the docs site's styles more specific, and avoid it affecting the header and footer copied over, the
#docsmainwrapper element is introduced and used in styles selectors.In the aftermath I had to clean up a lot.
Preview