Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node pool and AZ Tutorials #2367

Merged
merged 29 commits into from
Dec 5, 2024
Merged

Node pool and AZ Tutorials #2367

merged 29 commits into from
Dec 5, 2024

Conversation

pipo02mix
Copy link
Contributor

What this PR does / why we need it

Tutorials https://github.com/giantswarm/giantswarm/issues/29503

Things to check/remember before submitting

  • If you made content changes

    • Run make lint dev to render and proofread content changes locally.
    • Bump last_review_date in the front matter header if you reviewed the entire page.

@pipo02mix pipo02mix requested a review from a team as a code owner November 29, 2024 15:10
@pipo02mix pipo02mix self-assigned this Nov 29, 2024
@pipo02mix pipo02mix requested a review from a team November 29, 2024 15:10
@pipo02mix pipo02mix changed the title Tutorial clusters Node pool and AZ Tutorials Nov 29, 2024
@pipo02mix
Copy link
Contributor Author

@giantswarm/team-phoenix can you give it another look? I added the tab panel for each provider to configure AZs

https://github.com/giantswarm/docs/pull/2367/files#diff-a9d3d264096042ee5b85657e56d8e61aca8b9e05fd05b96d58c7e0ec728dbcd5R115

@pipo02mix pipo02mix enabled auto-merge (squash) December 5, 2024 14:41
@pipo02mix
Copy link
Contributor Author

I go ahead with current version

@pipo02mix pipo02mix merged commit 2de9e29 into main Dec 5, 2024
5 of 6 checks passed
@pipo02mix pipo02mix deleted the tutorial-clusters branch December 5, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants