Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dex OIDC docs with CAPA EKS cluster changes #2190

Merged
merged 6 commits into from
Apr 25, 2024
Merged

Conversation

tuladhar
Copy link
Contributor

@tuladhar tuladhar commented Apr 25, 2024

Towards giantswarm/roadmap#3389

What this PR does / why we need it

  • In order to get Dex working for CAPA EKS workload cluster, Athena needs to be configured to use AWS-provided EKS API server endpoint. This PR fixes the docs to mention that.
  • The oidc property on EKS is different (global.controlPlane. oidcIdentityProviderConfig than other CAPI provider (global.controlPlane.oidc), as such added new section for it.

Things to check/remember before submitting

  • If you made content changes

    • Run make dev to render and proofread content changes locally.
    • Bump last_review_date in the front matter header if you reviewed the entire page.

@tuladhar tuladhar requested a review from a team as a code owner April 25, 2024 07:58
@tuladhar tuladhar requested a review from a team April 25, 2024 07:58
@tuladhar tuladhar changed the title Update Athena configuration for Dex to work on CAPA EKS cluster Update Dex OIDC docs with CAPA EKS cluster changes Apr 25, 2024
@tuladhar tuladhar mentioned this pull request Apr 25, 2024
2 tasks
@tuladhar tuladhar requested a review from anvddriesch April 25, 2024 10:03
Copy link
Contributor

@pipo02mix pipo02mix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor suggestion but LGTM

@tuladhar tuladhar merged commit fa47f54 into main Apr 25, 2024
8 checks passed
@tuladhar tuladhar deleted the bigmac/dex-eks branch April 25, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants