Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting started sections #2169
Getting started sections #2169
Changes from 6 commits
3ffd0da
ce2f311
546d822
e69387c
a1bddeb
bbc9d85
2db0567
017f685
4ed46c6
e9d2f40
47a9b65
6d2b652
13d192d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should mention "first". There's no difference for the first one and subsequent clusters, and this marks it as beginner article unnecessarily.
"Configure and provision" is also too much. Those words add no value and can only create confusion. It's not much more than one simple step, so we should describe it as such (= "create").
This was our previous title (changed to active tense, while previously we had "Creat_ing_ ... install_ing_ ..."):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at it from a customer onboarding journey, so I thought
first
was a good idea but I am good with your pointThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 3 sentences don't match up.
The user does not configure the app platform or environment. They install a glorified Helm chart with simple tooling, or in summary, install an app (and maybe make minor
.Values.xyz
choices).Let's also rename the directory accordingly once we've found a matching title here.
My first idea:
Not really sure – are we giving an overview of the app platform here? I rather would not do that in this article. It should remain instructional. Explaining how to find an app (happa/catalog) and install it (with one, very typical example such as nginx-ingress) should suffice here, so we don't explode the scope. So maybe rather:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it is a practical intro to go across entire platform journey
Check failure on line 14 in src/content/getting started/configure-app-platform-to-build-your-capabilities/_index.md
GitHub Actions / Front matter problems
Found 1 severe problems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do we mean by "your app"? I guess GS managed apps and not really customer workloads (since they would have to use our observability tooling for that)?
Maybe:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the entire Getting Started is a journey, the app that you install in the step before is the one we use to show the logs or security feature in next sections