Add docs about CAPI node pools #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiunchinho
force-pushed
the
capi-nodepools
branch
from
f7ff23e to
c4de409
Compare
1 task
fiunchinho
force-pushed
the
capi-nodepools
branch
from
3cded45 to
ba8c0f1
Compare
fiunchinho
force-pushed
the
capi-nodepools
branch
from
98cd486 to
7849619
Compare
calvix
reviewed
Nov 24, 2023
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
calvix
reviewed
Nov 24, 2023
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
calvix
reviewed
Nov 24, 2023
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
calvix
reviewed
Nov 24, 2023
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
calvix
reviewed
Nov 24, 2023
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
calvix
reviewed
Nov 24, 2023
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
|
Comment from standup: let's note down that renaming node pools is discouraged because Helm deletes the old one and adds the new one (different name = different object; not a real rename). We should recommend adding a new pool, waiting for it to be healthy, and then removing the old one. |
AndiDog
reviewed
Nov 27, 2023
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
src/content/advanced/cluster-management/node-pools-capi/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Andreas Sommer <[email protected]>
Co-authored-by: Andreas Sommer <[email protected]>
|
LGTM, but the build still fails (wrong You can run |
Fixed, and
|
AndiDog
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Towarsd giantswarm/roadmap#2984
Docs were missing for CAPI node pools. I also renamed current docs to
node-pools-vintage.Have you maintained the front matter?
(Please bump the last_review_date in case this qualifies as a review for an entire page. Provide user_questions which should be answered in the page. Provide a meaningful description.)