Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DNS dashboard to show memory usage correctly #656

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Update DNS dashboard to show memory usage correctly #656

merged 2 commits into from
Jan 10, 2025

Conversation

mcharriere
Copy link
Contributor

@mcharriere mcharriere commented Jan 10, 2025 •
edited
Loading

Signed-off-by: Matias Charriere [email protected]

This PR

  • Updates dashboard
  • Change memory usage metrics to cAdvisor metrics

Checklist

  • Update changelog in CHANGELOG.md in an end-user friendly language.

@mcharriere mcharriere requested a review from a team as a code owner January 10, 2025 09:18
@mcharriere
add changelog
7534c91 
Signed-off-by: Matias Charriere <[email protected]>
@mcharriere mcharriere requested a review from a team January 10, 2025 09:20
hervenicol
hervenicol approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have enjoyed a before/after screenshot 😜
Otherwise LGTM 👍

@mcharriere
Copy link
Contributor Author

I would have enjoyed a before/after screenshot

there are actually no visual changes other than a dashed line for average. TL;DR go memstat is incomplete and not matching the real usage.

@mcharriere mcharriere merged commit d8c08b9 into main Jan 10, 2025
4 checks passed
@mcharriere mcharriere deleted the update-dns-mem-usage branch January 10, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weatherhog weatherhog weatherhog approved these changes

@hervenicol hervenicol hervenicol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcharriere @hervenicol @weatherhog