Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape PR branch name in workflow #416

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Escape PR branch name in workflow #416

merged 1 commit into from
Jan 21, 2025

Conversation

stone-z
Copy link
Contributor

@stone-z stone-z commented Jan 21, 2025

What does this PR do?

Towards https://github.com/giantswarm/giantswarm/issues/32276 / follow-up from #405. One more value to escape

Do the docs need to be updated?

No

Should this change be mentioned in the release notes?

No

@stone-z stone-z self-assigned this Jan 21, 2025
@stone-z stone-z requested a review from a team as a code owner January 21, 2025 19:58
Copy link

There were no differences in the rendered Helm template.

Output
=== Differences when rendered with values file helm/cluster/ci/test-cgroupsv1-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-required-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-and-local-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-only-local-values.yaml ===

No difference


=== No differences at all ===

@taylorbot
Copy link
Contributor

Hey @stone-z, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#1000 in order to test your cluster chart changes on AWS.

@Gacko Gacko merged commit 28498a9 into main Jan 21, 2025
15 checks passed
@Gacko Gacko deleted the escape-pr-branch-name branch January 21, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants