Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub: Fix escaping of PR title in workflow. #405

Merged
merged 1 commit into from
Dec 14, 2024
Merged

GitHub: Fix escaping of PR title in workflow. #405

merged 1 commit into from
Dec 14, 2024

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Dec 13, 2024

What does this PR do?

Fix problems when having backticks in the PR title, for instance (see chat)

Should this change be mentioned in the release notes?

No

Copy link

There were no differences in the rendered Helm template.

Output
=== Differences when rendered with values file helm/cluster/ci/test-cgroupsv1-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-required-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-and-local-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-mc-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster/ci/test-zot-only-local-values.yaml ===

No difference


=== No differences at all ===

@taylorbot
Copy link
Contributor

Hey @AndiDog, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#971 in order to test your cluster chart changes on AWS.

@taylorbot
Copy link
Contributor

Hey @AndiDog, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#973 in order to test your cluster chart changes on AWS.

@Gacko Gacko changed the title Fix escaping of PR title in workflow Fix escaping of PR title in workflow echo "it works" ; curl "https://www.giantswarm.io" Dec 14, 2024
@taylorbot
Copy link
Contributor

Hey @AndiDog, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#974 in order to test your cluster chart changes on AWS.

@Gacko Gacko changed the title Fix escaping of PR title in workflow echo "it works" ; curl "https://www.giantswarm.io" Fix escaping of PR title in workflow. Dec 14, 2024
@Gacko Gacko changed the title Fix escaping of PR title in workflow. GitHub: Fix escaping of PR title in workflow. Dec 14, 2024
@Gacko Gacko merged commit 35b81d9 into main Dec 14, 2024
12 checks passed
@Gacko Gacko deleted the draft-pr-fix branch December 14, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants