-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure cgroupsv1 per nodepool #368
Conversation
* Allow to configure cgroupsv1 per nodepool * Apply suggestions from code review Co-authored-by: Marco Ebert <[email protected]> * Regenerate docs * Move flatcar cgroupsv1 function to worker helper * Adjust tests to new containerd cgroups configuration * Apply suggestions from code review Co-authored-by: Andreas Sommer <[email protected]> * Still support old field --------- Co-authored-by: Marco Ebert <[email protected]> Co-authored-by: Andreas Sommer <[email protected]>
There were differences in the rendered Helm template, please check! Output
|
Hey @fiunchinho, a test pull request has been created for you in the cluster-aws repo! Go to pull request giantswarm/cluster-aws#902 in order to test your cluster chart changes on AWS. |
I changed the PR's title as there is, IMHO, no need to prefix it this way. Apart from that: LGTM! I guess you only cherry-picked, right? I guess it's currently hard to impossible to test stuff like this by just running cluster test suites, so we might need to come up with a test release that uses the test version of |
Yeah, basically cherry-picked and fixed conflicts. |
What does this PR do?
Backport of #348