-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cluster resource template #3
Conversation
8b30ba6
to
5c5b43d
Compare
359bb49
to
a82e315
Compare
It's expected that JSON schema validation is failing here, because the current validation has rules for existing cluster apps, and those rules do not work in the cluster chart. |
I know this PR is only taking the source from https://github.com/giantswarm/cluster-aws/blob/master/helm/cluster-aws/templates/_cluster.tpl. Feel free to merge 👍🏻 |
services: | ||
cidrBlocks: | ||
- 172.31.0.0/16 | ||
internal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would statically set these from the cluster-$provider
app in its Helm values like this:
cluster:
internal:
...
and these would be treated as an internal API, as in internal in our apps, where the cluster
chart exposes it to the cluster-$provider
, but it's not meant to be set by end users. This is roughly aligned with the current behavior of Values.internal
.
In a nutshell all initial PRs will be like that, with "just" make the templates being nicely configurable, so all providers can use them, so we have more work around Helm values and JSON schema in order to make this work nicely. |
Note: WIP, initially based on Cluster resource from cluster-aws.
What does this PR do?
(Please set a descriptive PR title. Use this space for additional explanations.)
What is the effect of this change to users?
Cluster resource is deployed.
How does it look like?
Any background context you can provide?
Working towards a PoC for restructured cluster apps (more details here).
What is needed from the reviewers?
PTAL :)
Do the docs need to be updated?
Not yet.
Should this change be mentioned in the release notes?