Make ASG lifecycle hook heartbeat timeout configurable

[AndiDog]

What this PR does / why we need it

Forward-port of #960

Towards https://github.com/giantswarm/giantswarm/issues/31843 and https://github.com/giantswarm/giantswarm/issues/32254

Checklist

• Updated CHANGELOG.md.

Trigger E2E tests

/run cluster-test-suites

[github-actions]

There were differences in the rendered Helm template, please check! ⚠️

Output

=== Differences when rendered with values file helm/cluster-aws/ci/test-auditd-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-eni-mode-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-lifecycle-hook-heartbeattimeout-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  ± value change
    - 30m
    + 60s



=== Differences when rendered with values file helm/cluster-aws/ci/test-local-registry-cache-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-mc-proxy-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-mc-proxy-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-authenticated-mirrors-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-multiple-service-account-issuers-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-network-topology-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-spot-instances-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-subnet-tags-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-pool0)
  ± value change
    - 30m
    + 1800s



=== Differences when rendered with values file helm/cluster-aws/ci/test-wc-minimal-values.yaml ===

/spec/lifecycleHooks/name=aws-node-termination-handler/heartbeatTimeout  (infrastructure.cluster.x-k8s.io/v1beta2/AWSMachinePool/org-giantswarm/test-wc-minimal-pool0)
  ± value change
    - 30m
    + 1800s

[AndiDog]

cluster-test-suites can't work due to the new aws-nth-bundle which the test doesn't allow adding through a /run comment. Since this worked in v1.1.5, I'll merge this as-is.

[tinkerers-ci]

Oh No! 😱 At least one test suite has failed during the AfterSuite cleanup stage and might have left around some resources on the MC!

Be sure to check the full results in Tekton Dashboard to see which test suite has failed and then run the following on the associated MC to list all leftover resources:

PIPELINE_RUN="pr-cluster-aws-965-cluster-test-suites2tfhq"

NAMES="$(kubectl api-resources --verbs list -o name | tr '\n' ,)"
kubectl get "${NAMES:0:${#NAMES}-1}" --show-kind --ignore-not-found -l cicd.giantswarm.io/pipelinerun=${PIPELINE_RUN} -A 2>/dev/null

[tinkerers-ci]

cluster-test-suites

Run name	pr-cluster-aws-965-cluster-test-suites2tfhq
Commit SHA	9cc9b81
Result	Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

---

Tip

To only re-run the failed test suites you can provide a TARGET_SUITES parameter with your trigger that points to the directory path of the test suites to run, e.g. /run cluster-test-suites TARGET_SUITES=./providers/capa/standard to re-run the CAPA standard test suite. This supports multiple test suites with each path separated by a comma.