-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aws-nth-bundle to use the MC's kubeconfig context if it's in a different organization namespace #959
Merged
AndiDog
merged 1 commit into
release-v1.1.x
from
nth-bundle-different-mc-kubeconfig-namespace
Dec 11, 2024
Merged
Fix aws-nth-bundle to use the MC's kubeconfig context if it's in a different organization namespace #959
AndiDog
merged 1 commit into
release-v1.1.x
from
nth-bundle-different-mc-kubeconfig-namespace
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent organization namespace
AndiDog
added
the
skip/ci
Instructs PR Gatekeeper to ignore any required PR checks
label
Dec 10, 2024
fiunchinho
approved these changes
Dec 10, 2024
AndiDog
force-pushed
the
nth-bundle-different-mc-kubeconfig-namespace
branch
from
December 11, 2024 07:45
4a0f41a
to
4d62fff
Compare
I reverted to the approved state and will put the other stuff in separate PRs |
There were differences in the rendered Helm template, please check! Output
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The
releases-test-suites
didn't work with cluster-aws v1.1.4 because if the MC is in a different namespace than the WC, as almost always, theHelmRelease
can't find the MC kubeconfig. And it doesn't allow specifying the secret's namespace either. So I switched toApp
's in-cluster feature.Checklist
Trigger E2E tests
cluster-test-suites won't work because the
Release
needs the new aws-nth-bundle app listed.I tested manually by creating a WC outside of
org-giantswarm
.