-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart availability zones #556
Conversation
…egion of choice rather than hardcoded values.
…egion of choice rather than hardcoded values.
…egion of choice rather than hardcoded values.
…egion of choice rather than hardcoded values.
@@ -12,5 +12,5 @@ If no region is provided in the values we'll attempt to look it up based on the | |||
{{- end }} | |||
{{- end }} | |||
{{- end }} | |||
{{- $region }} | |||
{{- required "Unable to default the region. Please set .global.providerSpecific.region" $region }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit out of scope for this PR.
We provide the "autodetect region" feature as an helper, but we should error if we're unable to provide a sane default.
/run cluster-test-suites |
cluster-test-suites
📋 View full results in Tekton Dashboard Rerun trigger: |
There were no differences in the rendered Helm template. Output
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
skipping CI blocker. failures are in the deletion phase and being worked on. |
What this PR does / why we need it
Towards: https://github.com/giantswarm/giantswarm/issues/30316
This PR makes 3 changes
azs-getter
folder to generate the above file automaticallythis is to replace the previous logic that hardcoded "a", "b" and "c" as az name for each region
Checklist
Trigger e2e tests
/run cluster-test-suites