Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart availability zones #556

Merged
merged 14 commits into from
Mar 26, 2024
Merged

Smart availability zones #556

merged 14 commits into from
Mar 26, 2024

Conversation

whites11
Copy link
Contributor

@whites11 whites11 commented Mar 21, 2024

What this PR does / why we need it

Towards: https://github.com/giantswarm/giantswarm/issues/30316

This PR makes 3 changes

  • changes the helm chart to use a yaml file (in files/azs-in-region.yaml) to get a list of azs in a region when defaulting such value
  • adds a go tool in the azs-getter folder to generate the above file automatically
  • adds a github action that runs once a day the above tool and creates a PR if any change happens

this is to replace the previous logic that hardcoded "a", "b" and "c" as az name for each region

Checklist

  • Update changelog in CHANGELOG.md.

Trigger e2e tests

/run cluster-test-suites

@@ -12,5 +12,5 @@ If no region is provided in the values we'll attempt to look it up based on the
{{- end }}
{{- end }}
{{- end }}
{{- $region }}
{{- required "Unable to default the region. Please set .global.providerSpecific.region" $region }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit out of scope for this PR.
We provide the "autodetect region" feature as an helper, but we should error if we're unable to provide a sane default.

@whites11
Copy link
Contributor Author

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Mar 25, 2024

cluster-test-suites

Run name pr-cluster-aws-556-cluster-test-suiteshggqh
Commit SHA dda6332
Result Failed ❌

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Copy link
Contributor

There were no differences in the rendered Helm template.

Output
=== Differences when rendered with values file helm/cluster-aws/ci/test-mc-proxy-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-network-topology-values.yaml ===

No difference


=== Differences when rendered with values file helm/cluster-aws/ci/test-wc-minimal-values.yaml ===

No difference

=== No differences at all ===

@whites11 whites11 self-assigned this Mar 25, 2024
@whites11 whites11 marked this pull request as ready for review March 25, 2024 11:55
@whites11 whites11 requested a review from a team as a code owner March 25, 2024 11:55
Copy link
Contributor

@calvix calvix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whites11
Copy link
Contributor Author

skipping CI blocker. failures are in the deletion phase and being worked on.

@whites11 whites11 added the skip/ci Instructs PR Gatekeeper to ignore any required PR checks label Mar 26, 2024
@whites11 whites11 merged commit 575ae3c into main Mar 26, 2024
14 checks passed
@whites11 whites11 deleted the smart-availability-zones branch March 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip/ci Instructs PR Gatekeeper to ignore any required PR checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants