Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy-support #105

Merged
merged 7 commits into from
Sep 6, 2022
Merged

proxy-support #105

merged 7 commits into from
Sep 6, 2022

Conversation

calvix
Copy link
Contributor

@calvix calvix commented Aug 25, 2022

@calvix calvix self-assigned this Aug 25, 2022
@tityosbot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@calvix calvix marked this pull request as ready for review September 6, 2022 08:18
@calvix calvix requested a review from a team September 6, 2022 08:18
@@ -88,6 +88,9 @@ spec:
{{- include "sshPostKubeadmCommands" . | nindent 2 }}
users:
{{- include "sshUsers" . | nindent 2 }}
files:
{{- include "sshFiles" $ | nindent 2 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's this line come from? Had we missed it off in the past?

Copy link
Contributor Author

@calvix calvix Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just adding a comment to it but it seems like it wasn't added at all :(

Yeah I found this is missing for some unknown reason

Copy link
Member

@AverageMarcus AverageMarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvix calvix merged commit b2811a5 into master Sep 6, 2022
@calvix calvix deleted the add-proxy-support branch September 6, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants