Skip to content

Commit

Permalink
Change schema validation allowing to add additional properties in `gl…
Browse files Browse the repository at this point in the history
…obal` (#435)

* Change schema validation allowing to add additional properties in `global`

* Change schema validation allowing to add additional properties in `global`
  • Loading branch information
njuettner authored Nov 23, 2023
1 parent d0f042d commit c61e183
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Changed

- Change schema validation allowing to add additional properties in `global`.
- Support longer node pool names and allow dashes

### Fixed
Expand Down
7 changes: 0 additions & 7 deletions helm/cluster-aws/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,6 @@ Properties within the `.metadata` top-level object
| `metadata.organization` | **Organization**|**Type:** `string`<br/>|
| `metadata.servicePriority` | **Service priority** - The relative importance of this cluster.|**Type:** `string`<br/>**Default:** `"highest"`|

### Metadata
Properties within the `.global.metadata` object

| **Property** | **Description** | **More Details** |
| :----------- | :-------------- | :--------------- |
| `global.metadata.preventDeletion` | **Prevent cluster deletion**|**Type:** `boolean`<br/>**Default:** `false`|

### Node pools
Properties within the `.nodePools` top-level object
Node pools of the cluster. If not specified, this defaults to the value of `internal.nodePools`.
Expand Down
2 changes: 1 addition & 1 deletion helm/cluster-aws/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@
"type": "object",
"title": "Global properties",
"description": "Properties that are available to all charts and subcharts.",
"additionalProperties": false,
"additionalProperties": true,
"properties": {
"metadata": {
"type": "object",
Expand Down

0 comments on commit c61e183

Please sign in to comment.