Skip to content

Commit

Permalink
add annotation for gc to cleanup loadbalancers (#593)
Browse files Browse the repository at this point in the history
  • Loading branch information
Berk Dehrioglu authored May 7, 2024
1 parent c9134ba commit 32d4a4d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Added an annotation to Kubernetes resources to resolve an issue where deletion was stuck due to hanging load balancers.

### Added

- Make Cilium ENI-based IP allocation configurable with high-level `global.connectivity.cilium.ipamMode` value. This feature was previously introduced as prototype and is now fully working.
Expand Down
1 change: 1 addition & 0 deletions helm/cluster-aws/templates/_aws_cluster.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ metadata:
cluster.x-k8s.io/paused: "true"
{{end}}
aws.cluster.x-k8s.io/external-resource-gc: "true"
aws.cluster.x-k8s.io/external-resource-tasks-gc: "load-balancer,security-group"
aws.giantswarm.io/vpc-endpoint-mode: "{{ .Values.global.connectivity.vpcEndpointMode }}"
network-topology.giantswarm.io/mode: "{{ .Values.global.connectivity.topology.mode }}"
{{- if .Values.global.connectivity.topology.transitGatewayId }}
Expand Down

0 comments on commit 32d4a4d

Please sign in to comment.