Skip to content

Commit

Permalink
Add short note regarding deletion - NTH may not be running anymore
Browse files Browse the repository at this point in the history
  • Loading branch information
AndiDog committed Dec 9, 2024
1 parent d2177bc commit 021f95e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions helm/cluster-aws/templates/aws-nth-helmrelease.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ awsNodeTerminationHandler:
registry: {{ include "awsContainerImageRegistry" $ }}

# Allow running on control plane nodes. On deletion, CAPI will first delete the worker nodes
# and we still want aws-node-termination-handler to take care of the last workers' EC2 lifecycle
# hooks since they otherwise won't be completed, resulting in unnecessary waiting time before
# AWS can terminate the instances
# (see `AWSMachinePool.spec.lifecycleHooks["aws-node-termination-handler"].heartbeatTimeout`).
# and we still want aws-node-termination-handler, if it's even still running and the HelmRelease
# not deleted yet, to take care of the last workers' EC2 lifecycle hooks since they otherwise
# won't be completed, resulting in unnecessary waiting time before AWS can terminate the
# instances (see `AWSMachinePool.spec.lifecycleHooks["aws-node-termination-handler"].heartbeatTimeout`).
# This runs on workers by default but allows moving pods to control plane nodes. Requires
# queue processing mode i.e. running as `Deployment`, not `DaemonSet`.
affinity:
Expand Down

0 comments on commit 021f95e

Please sign in to comment.