Do not generate proxy env secret for non private clusters. #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erkanerol
reviewed
Feb 14, 2024
mcharriere
reviewed
Feb 14, 2024
ljakimczuk
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards: https://github.com/giantswarm/giantswarm/issues/29836
since cluster-apps-operator is one single instance running in the MC, if the MC is private and cluster-apps-operator is configured to inject proxy envs, it does that for all WCs as well even if they're not private.
This PR prevents that from happening by checking if the Cluster is a private one to choose if it needs to generate the proxy env secret.
Tested on goat and it works fine, at least on CAPA.
Checklist