set external dns ip to empty value in all vsphere clusters (#551)

* set dnsup to empty value in all vsphere clusters * changelog
giantswarm · Nov 27, 2024 · 817b20e · 817b20e
1 parent 7eb9591
commit 817b20e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Set `ExternalDNSIP` to an empty value in the cluster values configmap for all vsphere clusters.
+
 ## [3.0.0] - 2024-11-19
 
 ### Removed

diff --git a/service/controller/resource/clusterconfigmap/desired.go b/service/controller/resource/clusterconfigmap/desired.go
@@ -268,10 +268,10 @@ func (r *Resource) GetDesiredState(ctx context.Context, obj interface{}) ([]*cor
 		}
 	}
 
-	// if we explicitly set externalDNSIP to "" it will cause to install chart-operator in mode that is compatible with private clusters
+	// if we explicitly set externalDNSIP to "" it will cause to install chart-operator in mode that is compatible with private clusters and all vsphere clusters
 	// as externalDNSIP is used as test DNS and default value is public google dns, but there isn't any value that could be used in private clusters
 	// as the cloud providers have unpredictable DNS ip depending on which subnet is the machine and pod running.
-	if privateCluster {
+	if privateCluster || provider == infra.VSphereClusterKindProvider {
 		emptyValue := ""
 		clusterValues.ExternalDNSIP = &emptyValue
 		clusterValues.Cluster.Private = true