Skip to content

Commit

Permalink
Do not generate proxy env secret for non private clusters.
Browse files Browse the repository at this point in the history
  • Loading branch information
whites11 committed Feb 14, 2024
1 parent 9cd3267 commit 5a023da
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions service/internal/privatecluster/privatecluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ import (
infra "github.com/giantswarm/cluster-apps-operator/v2/service/internal/infrastructure"
)

// IsPrivateCluster returns true if the cluster is a private cluster (i.e. it has no direct internet access).
// -In CAPZ and CAPA, we respect WC attributes. A non-private WC can exist in a private MC
// - In CAPV and CAPVCD, we respect MC attributes. If MC is private, all WCs are private.
// - In CAPG, we don’t have private concept.
func IsPrivateCluster(ctx context.Context, logger micrologger.Logger, ctrlclient client.Client, cr capi.Cluster) (bool, error) {
var privateCluster bool
var err error
Expand Down

0 comments on commit 5a023da

Please sign in to comment.