Skip to content

Commit

Permalink
Default clusterIssuer to letsencrypt-giantswarm and update ingress an…
Browse files Browse the repository at this point in the history
…notation (#334)
  • Loading branch information
tuladhar authored Jun 12, 2024
1 parent bd75b28 commit 3847424
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Default clusterIssuer to letsencrypt-giantswarm and update ingress annotation

## [1.12.1] - 2023-12-11

### Changed
Expand Down
4 changes: 0 additions & 4 deletions helm/athena/templates/ingress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@ metadata:
labels:
{{- include "athena.labels.common" . | nindent 4 }}
annotations:
{{- if .Values.ingress.tls.letsencrypt }}
cert-manager.io/cluster-issuer: letsencrypt-giantswarm
{{- else if ne .Values.ingress.tls.clusterIssuer "" }}
cert-manager.io/cluster-issuer: {{ .Values.ingress.tls.clusterIssuer }}
{{- end }}
{{- if .Values.security.subnet.restrictAccess.gsAPI }}
nginx.ingress.kubernetes.io/whitelist-source-range: {{ template "whitelistCIDR" . }}
{{- end }}
Expand Down
2 changes: 1 addition & 1 deletion helm/athena/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ ingress:
externalDNS: false
tls:
letsencrypt: true
clusterIssuer: ""
clusterIssuer: "letsencrypt-giantswarm"
crtPemB64: ""
keyPemB64: ""

Expand Down

0 comments on commit 3847424

Please sign in to comment.