Ensure WC is deleted even if App uninstall fails (#64)

Signed-off-by: Marcus Noble <[email protected]>

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Ensure WC is always deleted during AfterSuite even if App uninstall fails
 - Handle providers with consolidated default-apps
 
 ## [1.1.2] - 2024-05-20

pkg/suite/suite.go

@@ -261,14 +261,17 @@ func (s *suite) Run(t *testing.T, suiteName string) {
 	})
 
 	AfterSuite(func() {
+		defer func() {
+			// We defer this to ensure it happens even if uninstalling the app fails
+			logger.Log("Deleting workload cluster")
+			err := teardown.New(state.GetFramework()).Teardown(state.GetCluster())
+			Expect(err).NotTo(HaveOccurred())
+		}()
+
 		app := getInstallApp()
 		logger.Log("Uninstalling App %s", app.AppName)
 		err := state.GetFramework().MC().DeleteApp(state.GetContext(), *app)
 		Expect(err).NotTo(HaveOccurred())
-
-		logger.Log("Deleting workload cluster")
-		err = teardown.New(state.GetFramework()).Teardown(state.GetCluster())
-		Expect(err).NotTo(HaveOccurred())
 	})
 
 	Describe("", func() {