fix: button + divider typing issues

giantnodes · Apr 21, 2024 · ecd41c7 · ecd41c7
1 parent 45053bd
commit ecd41c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/react/src/components/button/Button.tsx b/packages/react/src/components/button/Button.tsx
@@ -10,7 +10,9 @@ import Spinner from '@/components/spinner/Spinner'
 
 const __ELEMENT_TYPE__ = 'button'
 
-type ComponentOwnProps = ButtonVariantProps & Omit<ButtonProps, 'children'>
+type ComponentOwnProps = ButtonVariantProps & {
+  isLoading?: boolean
+}
 
 type ComponentProps<T extends React.ElementType> = Polymophic.ComponentPropsWithRef<T, ComponentOwnProps>
 

diff --git a/packages/react/src/components/divider/Divider.tsx b/packages/react/src/components/divider/Divider.tsx
@@ -6,9 +6,7 @@ import React from 'react'
 
 const __ELEMENT_TYPE__ = 'hr'
 
-type ComponentOwnProps = DividerVariantProps & {
-  icon: React.ReactNode
-}
+type ComponentOwnProps = DividerVariantProps
 
 type ComponentProps<T extends React.ElementType> = Polymophic.ComponentPropsWithRef<T, ComponentOwnProps>