Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify bool usages #90

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Simplify bool usages #90

merged 1 commit into from
Jul 30, 2023

Conversation

kenrap
Copy link
Contributor

@kenrap kenrap commented Jul 29, 2023

No description provided.

@kenrap kenrap requested a review from a team as a code owner July 29, 2023 15:09
ericbsd
ericbsd requested changes Jul 30, 2023
View reviewed changes
Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a fan of for loop. If could change that to use RW it would be great.

src/auto-switch.py Outdated
]
inets = [
inet in nic_ifconfig
for inet in ['inet ', 'inet6']
Copy link
Member

@ericbsd ericbsd Jul 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re should be used here instead of for loop.

src/auto-switch.py Outdated
break
status = [
f"status: {status_type}" in nic_ifconfig
for status_type in ['active', 'associated']
Copy link
Member

@ericbsd ericbsd Jul 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re should be used here instead of for loop.

@ericbsd
Copy link
Member

ericbsd commented Jul 30, 2023

Make sure to resolve the conflict and to do the request and I will merge it.

@ericbsd ericbsd added the feature New feature or request label Jul 30, 2023
ericbsd
ericbsd approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@ericbsd ericbsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericbsd ericbsd merged commit 3789efe into ghostbsd:master Jul 30, 2023
@ericbsd
Copy link
Member

ericbsd commented Jul 30, 2023

Thanks for the contribution.

@kenrap kenrap deleted the simplify-bool branch August 4, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericbsd ericbsd ericbsd approved these changes

Assignees

@kenrap kenrap

Labels
feature New feature or request
Projects
Development Management
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenrap @ericbsd