Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md python version #108

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Update README.md python version #108

merged 1 commit into from
Jul 24, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Jul 23, 2024

Summary by Sourcery

This pull request updates the README.md file to specify the new required Python version (3.11) for installing NetworkMgr, replacing the previous version (3.8).

  • Documentation:
    • Updated the README.md to reflect the change in the required Python version from 3.8 to 3.11 for installing NetworkMgr.

@ericbsd ericbsd requested review from a team as code owners July 23, 2024 21:16
Copy link

sourcery-ai bot commented Jul 23, 2024

Reviewer's Guide by Sourcery

This pull request updates the README.md file to reflect the change in the required Python version from 3.8 to 3.11 for installing NetworkMgr. The change ensures that users install the correct version of Python and its associated packages.

File-Level Changes

Files Changes
README.md Updated the required Python version for installation from 3.8 to 3.11.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

README.md Show resolved Hide resolved
@ericbsd ericbsd merged commit 1961608 into master Jul 24, 2024
1 check passed
@ericbsd ericbsd deleted the ericbsd-patch-1 branch July 24, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant