Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back gzip to BIOS /boot/loader #342

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Add back gzip to BIOS /boot/loader #342

merged 2 commits into from
Sep 8, 2024

Conversation

ericbsd
Copy link
Member

@ericbsd ericbsd commented Sep 8, 2024

Gzip is needed for the GhostBSD image legacy boot.

This should take care of ghostbsd/issues#172.

Summary by Sourcery

Enable gzip support in the BIOS /boot/loader to support legacy boot for GhostBSD images.

Gzip is needed for the GhostBSD image legacy boot.
@ericbsd ericbsd self-assigned this Sep 8, 2024
@ericbsd ericbsd requested review from a team as code owners September 8, 2024 02:42
Copy link

sourcery-ai bot commented Sep 8, 2024

Reviewer's Guide by Sourcery

This pull request re-enables gzip support in the BIOS /boot/loader by modifying the Makefile. The change is necessary for the GhostBSD image legacy boot and addresses a specific issue in the project.

File-Level Changes

Change Details Files
Re-enabled gzip support in the BIOS /boot/loader
  • Changed LOADER_GZIP_SUPPORT from 'no' to 'yes'
  • Added a comment explaining the reason for not setting gzip support to 'no'
stand/i386/loader/Makefile

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericbsd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider improving the inline comment to provide more context, such as 'Enable gzip support for GhostBSD legacy boot' or 'Enable gzip support (fixes #172)'.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@ericbsd ericbsd merged commit 5b377a3 into stable/14 Sep 8, 2024
1 check passed
@ericbsd ericbsd deleted the ericbsd-patch-1 branch September 8, 2024 11:25
@ericbsd ericbsd added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant