Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate the proper counts for facets #32

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Calculate the proper counts for facets #32

merged 2 commits into from
Aug 8, 2024

Conversation

Cito
Copy link
Member

@Cito Cito commented Aug 7, 2024 •
edited
Loading

  • Calculate the proper counts in facets (we want to have the number of datasets, not the number of occurrences)

@Cito Cito added the build label Aug 7, 2024
@coveralls
Copy link

coveralls commented Aug 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10293496729

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 90.234%
Totals Coverage Status
Change from base Build 10284029681: 0.04%
Covered Lines: 462
Relevant Lines: 512
💛 - Coveralls

@Cito Cito removed the build label Aug 7, 2024
@Cito Cito requested review from lkuchenb and dontseyit August 8, 2024 07:13
@dontseyit dontseyit merged commit f6dc92d into main Aug 8, 2024
9 checks passed
@dontseyit dontseyit deleted the fix/facet-counts branch August 8, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontseyit dontseyit dontseyit approved these changes

@lkuchenb lkuchenb Awaiting requested review from lkuchenb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cito @coveralls @dontseyit