Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status code for missing IVA ID #18

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Conversation

Cito
Copy link
Member

@Cito Cito commented Jun 17, 2024

When there was no IVA pre-specified in the access request, and the PATH request to grant an access request didn't contain an IVA ID either, a 500 status code was returned instead of a 422 status code.

This PR also updates dependencies and template files. Particularly, hexkit is updated and fixtures needed to be adapted.

@coveralls
Copy link

coveralls commented Jun 17, 2024

Pull Request Test Coverage Report for Build 9546934921

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 88.592%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ars/adapters/inbound/fastapi_/routes.py 0 1 0.0%
Totals Coverage Status
Change from base Build 8896592768: -0.04%
Covered Lines: 365
Relevant Lines: 412

💛 - Coveralls

@Cito Cito requested a review from TheByronHimes June 17, 2024 11:37
@Cito Cito merged commit 1785920 into main Jun 17, 2024
9 checks passed
@Cito Cito deleted the fix/status-for-missing-iva-id branch June 17, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants