Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template files and dependencies #10

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Update template files and dependencies #10

merged 8 commits into from
Dec 6, 2023

Conversation

Cito
Copy link
Member

@Cito Cito commented Dec 5, 2023 •
edited
Loading

This PR just updates the template files and dependencies. No changes to the code besides adaptations to the updates.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7113843133

  • 13 of 13 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.663%
Totals Coverage Status
Change from base Build 6767413856: 0.0%
Covered Lines: 399
Relevant Lines: 445
💛 - Coveralls

@Cito Cito changed the title Update template files Update template files and dependencies Dec 5, 2023
@Cito Cito requested a review from TheByronHimes December 6, 2023 09:19
TheByronHimes
TheByronHimes previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently learned about the f-string use I listed below. Just wanted to share it, not necessarily suggesting the change.

tests/fixtures/auth_keys.py Outdated Show resolved Hide resolved
@Cito @TheByronHimes
Use new f-string feature
99a1c4a 
Co-authored-by: Byron Himes <[email protected]>
@Cito Cito requested a review from TheByronHimes December 6, 2023 11:32
@Cito Cito merged commit f6d9a58 into main Dec 6, 2023
8 checks passed
@Cito Cito deleted the feature/update-template-files branch December 6, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheByronHimes TheByronHimes TheByronHimes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cito @TheByronHimes