[eclipse-cdt#242] Make ClangdConfigurationFileManager public API

since its needed by some vendors to overwrite certain methods it should be made available.
ghentschke · Mar 5, 2024 · d006aee · d006aee
1 parent 0b3b624
commit d006aee
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/bundles/org.eclipse.cdt.lsp.clangd/META-INF/MANIFEST.MF b/bundles/org.eclipse.cdt.lsp.clangd/META-INF/MANIFEST.MF
@@ -28,9 +28,9 @@ Require-Bundle: org.eclipse.cdt.lsp;bundle-version="0.0.0",
  org.eclipse.ui.workbench.texteditor;bundle-version="0.0.0",
  org.eclipse.core.variables;bundle-version="0.0.0",
  org.yaml.snakeyaml;bundle-version="0.0.0"
-Service-Component: OSGI-INF/org.eclipse.cdt.lsp.clangd.internal.config.BuiltinClangdOptionsDefaults.xml,
+Service-Component: OSGI-INF/org.eclipse.cdt.lsp.clangd.ClangdConfigurationFileManager.xml,
+ OSGI-INF/org.eclipse.cdt.lsp.clangd.internal.config.BuiltinClangdOptionsDefaults.xml,
  OSGI-INF/org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigurationAccess.xml,
- OSGI-INF/org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigurationFileManager.xml,
  OSGI-INF/org.eclipse.cdt.lsp.clangd.internal.config.ClangdFallbackManager.xml,
  OSGI-INF/org.eclipse.cdt.lsp.clangd.internal.config.ClangdMetadataDefaults.xml
 Bundle-Activator: org.eclipse.cdt.lsp.clangd.plugin.ClangdPlugin
diff --git a/...config.ClangdConfigurationFileManager.xml → ...clangd.ClangdConfigurationFileManager.xml b/...config.ClangdConfigurationFileManager.xml → ...clangd.ClangdConfigurationFileManager.xml
@@ -1,9 +1,9 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.3.0" name="org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigurationFileManager">
+<scr:component xmlns:scr="http://www.osgi.org/xmlns/scr/v1.3.0" name="org.eclipse.cdt.lsp.clangd.ClangdConfigurationFileManager">
  <property name="service.ranking" type="Integer" value="0"/>
  <service>
  <provide interface="org.eclipse.cdt.lsp.clangd.ClangdCProjectDescriptionListener"/>
  </service>
  <reference cardinality="1..1" field="build" interface="org.eclipse.cdt.core.build.ICBuildConfigurationManager" name="build"/>
- <implementation class="org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigurationFileManager"/>
+ <implementation class="org.eclipse.cdt.lsp.clangd.ClangdConfigurationFileManager"/>
 </scr:component>
diff --git a/...onfig/ClangdConfigurationFileManager.java → ...langd/ClangdConfigurationFileManager.java b/...onfig/ClangdConfigurationFileManager.java → ...langd/ClangdConfigurationFileManager.java
@@ -11,7 +11,7 @@
  * Gesa Hentschke (Bachmann electronic GmbH) - initial implementation
  *******************************************************************************/
 
-package org.eclipse.cdt.lsp.clangd.internal.config;
+package org.eclipse.cdt.lsp.clangd;
 
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
@@ -26,8 +26,6 @@
 import org.eclipse.cdt.core.settings.model.CProjectDescriptionEvent;
 import org.eclipse.cdt.core.settings.model.ICConfigurationDescription;
 import org.eclipse.cdt.core.settings.model.ICProjectDescription;
-import org.eclipse.cdt.lsp.clangd.ClangdCProjectDescriptionListener;
-import org.eclipse.cdt.lsp.clangd.MacroResolver;
 import org.eclipse.cdt.lsp.plugin.LspPlugin;
 import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IProject;

diff --git a/...clangd.tests/src/org/eclipse/cdt/lsp/clangd/tests/ClangdConfigurationFileManagerTest.java b/...clangd.tests/src/org/eclipse/cdt/lsp/clangd/tests/ClangdConfigurationFileManagerTest.java
@@ -33,8 +33,8 @@
 import org.eclipse.cdt.core.settings.model.ICProjectDescription;
 import org.eclipse.cdt.internal.core.settings.model.CConfigurationDescriptionCache;
 import org.eclipse.cdt.lsp.clangd.ClangdCProjectDescriptionListener;
+import org.eclipse.cdt.lsp.clangd.ClangdConfigurationFileManager;
 import org.eclipse.cdt.lsp.clangd.MacroResolver;
-import org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigurationFileManager;
 import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IProject;
 import org.eclipse.core.resources.IResource;

diff --git a/...angd.tests/src/org/eclipse/cdt/lsp/internal/clangd/tests/ClangdConfigFileCheckerTest.java b/...angd.tests/src/org/eclipse/cdt/lsp/internal/clangd/tests/ClangdConfigFileCheckerTest.java
@@ -20,9 +20,9 @@
 import java.io.IOException;
 import java.io.UnsupportedEncodingException;
 
+import org.eclipse.cdt.lsp.clangd.ClangdConfigurationFileManager;
 import org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigFileChecker;
 import org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigFileMonitor;
-import org.eclipse.cdt.lsp.clangd.internal.config.ClangdConfigurationFileManager;
 import org.eclipse.cdt.lsp.clangd.tests.TestUtils;
 import org.eclipse.core.resources.IFile;
 import org.eclipse.core.resources.IMarker;