feat(go binding): add beamsize/entropythold/maxcontext to context interface #2350
Conversation
|
@ggerganov I think the build failed for go building has been fixed. please check it. |
|
@ggerganov seems it didn't re-test automatically, require manually trigger |
|
Just triggered it again - let's see if it's green |
|
@ggerganov it is green now. it seems that we need a static library |
In what sense we need both? |
okey, so it is clear that this is NOT intentional... |
@ggerganov this CL makes much more sense now. |
Makefile
Outdated
| @@ -967,11 +967,14 @@ src/whisper.o: \ | |||
|
|
|||
| $(LIB_WHISPER): \ | |||
| $(OBJ_WHISPER) \ | |||
| $(OBJ_GGML) \ | |||
There was a problem hiding this comment.
I don't think it is necessary to include the ggml object files in the whisper dynamic lib. We want to link ggml dynamically
|
@ggerganov This issue may require your attention, as similar issues with Go bindings keep recurring. |
Makefile
Outdated
| $(OBJ_WHISPER) \ | ||
| $(OBJ_GGML) \ | ||
| $(LIB_GGML) |
There was a problem hiding this comment.
$(LIB_GGML) is not necessary, but $(OBJ_GGML) is required.
* ggerganov/master: (40 commits) revert : cmake : set MSVC to use UTF-8 on source files (ggerganov#2346) sync : ggml ggml: fix ggml_graph_cpy undefined behavior (ggml/943) cann : fix doxy (ggml/0) vulkan : fix build (llama/0) cuda : mark BF16 CONT as unsupported ggml : fix cont with transposed tensors when one dimension is 1 (ggml/934) cmake : set MSVC to use UTF-8 on source files (ggerganov#2346) readme : remove invalid flag from Python example (ggerganov#2396) readme : fix link (ggerganov#2394) go : add beamsize/entropythold/maxcontext to context interface (ggerganov#2350) talk-llama : sync llama.cpp whisper : update FA call sync : ggml sync : vulkan (skip) (llama/0) ggml : do not crash when quantizing q4_x_x with an imatrix (llama/9192) metal : separate scale and mask from QKT in FA kernel (llama/9189) ggml : add SSM Metal kernels (llama/8546) metal : gemma2 flash attention support (llama/9159) CPU/CUDA: Gemma 2 FlashAttention support (llama/8542) ...
…anov#2350) * feat(go binding): add beamsize/entropythold/maxcontext to context interface fixes: ggerganov#2349 * fix go building build * fix dynamic link .so and header.h * remove LD_LIBRARY_PATH * remove ggml obj from whisper dynamic lib * drop LIB_GGML
…anov#2350) * feat(go binding): add beamsize/entropythold/maxcontext to context interface fixes: ggerganov#2349 * fix go building build * fix dynamic link .so and header.h * remove LD_LIBRARY_PATH * remove ggml obj from whisper dynamic lib * drop LIB_GGML
…anov#2350) * feat(go binding): add beamsize/entropythold/maxcontext to context interface fixes: ggerganov#2349 * fix go building build * fix dynamic link .so and header.h * remove LD_LIBRARY_PATH * remove ggml obj from whisper dynamic lib * drop LIB_GGML
fixes: #2349