Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as discussed in #112, I reworked the open_in_youtube-skill.
Its still a requests.get without using any api or ned of any api-key.
Instead of using bs4, i regex-search for the javascript initialization-data, transform the json-string and use glom to extract the deeply nested video url as well as video title.
Other changes:
if reg_ex
so Jarvis will not silently fail/get "stuck" with theINFO - Executing skill open_in_youtube
-message if one just say 'play', cause it looks like a freeze