Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minor ray tracing tests #6651

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Add minor ray tracing tests #6651

merged 3 commits into from
Dec 3, 2024

Conversation

Vecvec
Copy link
Contributor

@Vecvec Vecvec commented Dec 3, 2024

Connections
fixes #6646

Description
adds tests the early returns by calling the functions with empty iterators.

Testing
This adds a new test that passes

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown N/A
    • --target wasm32-unknown-emscripten N/A
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@Vecvec Vecvec requested a review from a team as a code owner December 3, 2024 05:49
Copy link
Member

@teoxoy teoxoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@teoxoy teoxoy merged commit ed2940d into gfx-rs:trunk Dec 3, 2024
27 checks passed
@cwfitzgerald cwfitzgerald deleted the ray-tracing-tests branch December 3, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Ray tracing is missing some minor test coverage
2 participants