Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using FXC as fallback #6643

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Avoid using FXC as fallback #6643

merged 4 commits into from
Dec 2, 2024

Conversation

teoxoy
Copy link
Member

@teoxoy teoxoy commented Dec 2, 2024 •
edited
Loading

Fixes #6568

@teoxoy teoxoy requested a review from nical December 2, 2024 15:29
@teoxoy teoxoy requested a review from a team as a code owner December 2, 2024 15:29
@teoxoy
Copy link
Member Author

teoxoy commented Dec 2, 2024

I also removed the searching behavior for the dlls as it can be problematic as well (#6200 (comment)).

@teoxoy teoxoy merged commit 66d51b6 into gfx-rs:trunk Dec 2, 2024
27 checks passed
@teoxoy teoxoy deleted the dxc branch December 2, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nical nical nical approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The d3d12 backend silently falls back to FXC if loading DXC fails
2 participants
@teoxoy @nical