[wgpu-core] ray tracing follow-up #6552
Open
+132
−677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ray Tracing tests passed on my computer. |
|
Demoting to draft while dependents get worked on. |
|
@cwfitzgerald: But...that PR has already been pretty thoroughly reviewed, it's just waiting on @jimblandy to finish a minor change so that it can merge. It feels like this PR really is |
|
We should probably unify policy on this at some point, from my perspective there was a bunch of stuff going on in the base PR, I have no idea how complete or what change sets actually matter (is this PR even up to date with the current state of the dependency). Which is not really reviewable without extra instructions. |
…writes The acceleration structures are already being kept alive by the tracker in the command encoder.
…coderInFlight`, remove it from `ActiveSubmission` Use `CommandBufferMutable.temp_resources` to store the ray tracing related staging buffers and scratch buffers. These shouldn't have been stored in `PendingWrites.temp_resources` because they can get destroyed early (before the command buffer that uses them has been submitted) if any other command buffer gets submitted first.
`Tlas.destroy` didn't check if the `Tlas` is used in a bind group of an active submission. The only reason we need the `destroy` methods for textures and buffers is because they allow users to eagerly release memory in browser implementations. I think we can remove the destroy methods on the acceleration structures for now as they complicate the picture without any gain. If they will be needed for Firefox we can add them back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6291.
Depends on #6544.