[naga spv-out] Expand LocalType to permit pointers to matrices. #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the free function `back::spv::make_local` into an associated function `LocalType::from_inner`.
In `back::spv`: - Factor out the numeric variants of `LocalType` into a new enum, `NumericType`. - Split the `Value` variant into `Numeric` and `LocalPointer` variants, and let `LocalPointer` point to any numeric type, including matrices. In subsequent commits, we'll need to spill matrices out into temporary local variables. This means we'll need to generate SPIR-V pointer-to-matrix types, so `LocalType` needs to be able to represent that.
jimblandy
added
area: naga back-end
|
This PR is big, but boring. All it's doing is rearranging some enums... that happen to be widely used 😭 |
3 tasks
teoxoy
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
back::spv:Factor out the numeric variants of
LocalTypeinto a new enum,NumericType.Split the
Valuevariant intoNumericandLocalPointervariants, and letLocalPointerpoint to any numeric type, including matrices.In subsequent PRs, we'll need to spill matrices out into temporary local variables. This means we'll need to generate SPIR-V pointer-to-matrix types, so
LocalTypeneeds to be able to represent that.Rename
make_localtoLocalType::from_inner.Change the free function
back::spv::make_localinto an associated functionLocalType::from_inner.