DO NOT MERGE: REBASE: feature: Parse enable directives & SHADER-F16 support #6365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Break out `word_as_ident*` helpers to keep validation of identifiers DRY. 2. Add `peek_*` variants. TODO: Pending validation from @jimb at <https://matrix.to/#/!fjjkgHFcwtkREywzfk:matrix.org/$feC_32iRis6rk0hiqm-gysIzljXNSfVmbNTBJAjlhKY?via=matrix.org&via=mozilla.org&via=ralith.com>
ErichDonGubler
force-pushed
the
feature/enable
branch
4 times, most recently
from
7d06abc
to
0c4ee78
Compare
ErichDonGubler
changed the title
ErichDonGubler
force-pushed
the
feature/enable
branch
2 times, most recently
from
f4e1d2e
to
b936c71
Compare
ErichDonGubler
force-pushed
the
feature/enable
branch
from
b936c71
to
c51ab09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and maybe do s'more work with #5701.