Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse diagnostic(…) attributes on fns #6353

Draft
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Draft

Parse diagnostic(…) attributes on fns #6353

wants to merge 12 commits into from

Commits on Oct 3, 2024

  1. WIP: refactor(wgsl-in): add peeking variants of Lexer::next_ident* 

    1. Break out `word_as_ident*` helpers to keep validation of identifiers
   DRY.
2. Add `peek_*` variants.

TODO: Pending validation from @jimb at
<https://matrix.to/#/!fjjkgHFcwtkREywzfk:matrix.org/$feC_32iRis6rk0hiqm-gysIzljXNSfVmbNTBJAjlhKY?via=matrix.org&via=mozilla.org&via=ralith.com>
    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    fc4f811 View commit details
    Browse the repository at this point in the history

  2. feat(wgsl-in): create skeleton for parsing directives

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d8e73a7 View commit details
    Browse the repository at this point in the history

  3. WIP: add tests for unsupported and out-of-order directives

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b0c008b View commit details
    Browse the repository at this point in the history

  4. refactor(wgsl-in): specify more closure ret. types in parsing 

    This resolves ambiguity that will be introduced in the subsequent commit
that adds `impl From<ConflictingDiagnosticRuleError> for naga::Error`.
    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    50e70f8 View commit details
    Browse the repository at this point in the history

  5. feat: impl Eq for naga::Span

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e9852b7 View commit details
    Browse the repository at this point in the history

  6. feat: impl Hash for naga::Span

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    7e54abf View commit details
    Browse the repository at this point in the history

  7. WIP: feat(wgsl-in): parse diagnostic(…) directives (with no effect)

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9805368 View commit details
    Browse the repository at this point in the history

  8. WIP: add tests for diagnostic directives

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2e7f0c8 View commit details
    Browse the repository at this point in the history

  9. WIP: refactor(wgsl-in): track parsed diagnostic directives

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9a40cf0 View commit details
    Browse the repository at this point in the history

  10. WIP: feat: filter uniformity analysis errors with `derivative_uniform… 

    …ity`
    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    cf23d97 View commit details
    Browse the repository at this point in the history

  11. WIP: feat(wgsl-in): parse diagnostic attrs. on fns

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    3cc8523 View commit details
    Browse the repository at this point in the history

  12. feat: impl FromStr for naga::wgsl::error::Severity

    @ErichDonGubler
    ErichDonGubler committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a954d89 View commit details
    Browse the repository at this point in the history