Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metal] Use objc2-metal #5641

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

[metal] Use objc2-metal #5641

wants to merge 6 commits into from

Commits on Jun 23, 2024

  1. Use objc2-metal with metal naming scheme

    To keep the diff smaller and easier to review, this uses a temporary
    fork of `objc2-metal` and `objc2-quartz-core` whose methods use the
    naming scheme of the `metal` crate.
    
    One particular difficult part with this is that the `metal` crate has
    several methods where the order of the arguments are swapped relative
    to the corresponding Objective-C methods.
    
    This includes most perilously (since these have both an offset and an
    index argument, both of which are integers):
    - `set_bytes`
    - `set_vertex_bytes`
    - `set_fragment_bytes`
    - `set_buffer`
    - `set_vertex_buffer`
    - `set_fragment_buffer`
    - `set_threadgroup_memory_length`
    
    But also:
    - `set_vertex_texture`
    - `set_fragment_texture`
    - `set_sampler_state`
    - `set_vertex_sampler_state`
    - `set_fragment_sampler_state`
    madsmtm committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    1573efd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    42b4a97 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    86a12fb View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    d7c2e7b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d34f025 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    1e04db3 View commit details
    Browse the repository at this point in the history