Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Ray tracing is missing some minor test coverage #6646

Closed
jimblandy opened this issue Dec 2, 2024 · 0 comments · Fixed by #6651
Closed

[core] Ray tracing is missing some minor test coverage #6646

jimblandy opened this issue Dec 2, 2024 · 0 comments · Fixed by #6651
Labels
area: tests Improvements or issues with our test suite

Comments

@jimblandy
Copy link
Member

The raytracing code contains some early returns here and here, which don't seem to be exercised by the current tests.

In reviewing #6544, I noticed that the PR had neglected to handle those early returns. Since the author of the PR had run the test suite, and the omission should have caused the test to fail, that indicates that these paths are not exercised by the current raytracing tests.
@jimblandy jimblandy added the area: tests Improvements or issues with our test suite label Dec 2, 2024
@Vecvec Vecvec mentioned this issue Dec 3, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tests Improvements or issues with our test suite
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add minor ray tracing tests Vecvec/wgpu
1 participant
@jimblandy